这是indexloc提供的服务，不要输入任何密码
Skip to content

Added isnan, isinf, and isclose #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 118 commits into from
Jul 12, 2022
Merged

Added isnan, isinf, and isclose #105

merged 118 commits into from
Jul 12, 2022

Conversation

@aletheia094
Copy link
Contributor

@aletheia094 aletheia094 commented Jun 18, 2022 •
edited
Loading

Added support for isnan, isinf, and isclose math functions.

Rhea Goyal and others added 30 commits June 2, 2022 14:25
added new tests (for already existing functions)
a5f387a
error running c++ test
af08dc3
error running c++ test
74fd57d
fixed part of c++ test
05d2d61
errors running python test
3af53a8
testing wrong list
fdbbba5
can't do arithmetic
160ad79
testing isinf
fe25196
rewrote isinf (using CreateICmpEQ)
878ee15
I'm an idiot
a857327
added tests for isclose and finished up create isnan
b264ce5
added create isnan to .h file
481faad
fixed error in mathfunctionstest
33ae114
c++ isnan test failing
2277fcc
c++ isnan test failing
3b7408e
c++ isnan test failing
8c265ec
still not working
5aaa720
hm not sure what's happening
503fc5e
hm not sure what's happening
fe23e41
hm not sure what's happening
5aad1ac
added isnan to math module
3bee044
was using integer cmp instead of float cmp
1c62647
not sure why assert is failing
168961a
see if this works
b6046ad
IT PASSED
46533e6
:wq
132b2fa
fixed errors
7fe9c72
reverting
07dd9ed
python float is c++ double
2478be1
using nan() instead
b93096b
LeonhardFS
LeonhardFS reviewed Jun 29, 2022
View reviewed changes
LeonhardFS
LeonhardFS reviewed Jul 12, 2022
View reviewed changes
LeonhardFS
LeonhardFS reviewed Jul 12, 2022
View reviewed changes
LeonhardFS
LeonhardFS reviewed Jul 12, 2022
View reviewed changes
LeonhardFS
LeonhardFS reviewed Jul 12, 2022
View reviewed changes
LeonhardFS
LeonhardFS reviewed Jul 12, 2022
View reviewed changes
LeonhardFS
LeonhardFS reviewed Jul 12, 2022
View reviewed changes
LeonhardFS
LeonhardFS reviewed Jul 12, 2022
View reviewed changes
LeonhardFS
LeonhardFS reviewed Jul 12, 2022
View reviewed changes
LeonhardFS
LeonhardFS reviewed Jul 12, 2022
View reviewed changes
LeonhardFS
LeonhardFS requested changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@LeonhardFS LeonhardFS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work here, couple minor things to fix (please address all the comments) before we can merge it.

@LeonhardFS LeonhardFS marked this pull request as ready for review July 12, 2022 16:54
@aletheia094 aletheia094 requested a review from LeonhardFS July 12, 2022 17:20
LeonhardFS
LeonhardFS approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@LeonhardFS LeonhardFS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go

@LeonhardFS LeonhardFS merged commit e78317e into tuplex:master Jul 12, 2022
@LeonhardFS LeonhardFS added enhancement New feature or request good first issue Good for newcomers labels Jul 12, 2022
@aletheia094 aletheia094 deleted the dev branch July 13, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LeonhardFS LeonhardFS LeonhardFS approved these changes

Assignees

@aletheia094 aletheia094

Labels

enhancement New feature or request good first issue Good for newcomers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aletheia094 @LeonhardFS