这是indexloc提供的服务，不要输入任何密码
Skip to content

crc32: add avx512 implementation #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 17, 2025
Merged

crc32: add avx512 implementation #422

merged 3 commits into from
Nov 17, 2025
+171 −29

Conversation

@folkertdev
Copy link
Member

@folkertdev folkertdev commented Nov 10, 2025 •
edited
Loading

Testing happens with miri, because the CI machines don't support avx512 of course.

@codecov
Copy link

codecov bot commented Nov 10, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
fuzz-compress 40.55% <0.00%> (+0.03%) ⬆️
fuzz-decompress 30.63% <100.00%> (-0.11%) ⬇️
test-aarch64-apple-darwin 92.07% <ø> (-1.50%) ⬇️
test-aarch64-unknown-linux-gnu 89.72% <ø> (-0.06%) ⬇️
test-i686-unknown-linux-gnu 89.48% <ø> (-0.05%) ⬇️
test-x86_64-apple-darwin 90.61% <100.00%> (-0.94%) ⬇️
test-x86_64-unknown-linux-gnu 92.43% <100.00%> (-1.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
zlib-rs/src/crc32.rs 94.11% <ø> (ø)
zlib-rs/src/crc32/pclmulqdq.rs 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@folkertdev folkertdev force-pushed the crc32-updates branch 4 times, most recently from cd70acf to e02132b Compare November 13, 2025 09:50
@folkertdev folkertdev requested a review from bjorn3 November 13, 2025 09:51
@folkertdev folkertdev force-pushed the crc32-updates branch 3 times, most recently from d645ed7 to 6d2808a Compare November 17, 2025 11:54
@bjorn3
Copy link
Collaborator

bjorn3 commented Nov 17, 2025

CI has a fuzzer failure.

@folkertdev
Copy link
Member Author

folkertdev commented Nov 17, 2025

Forgot to pin the libz-sys-ng version there (the latest version changes medium compression output slightly, which our tests/implementation don't yet account for). All good now.

bjorn3
bjorn3 reviewed Nov 17, 2025
View reviewed changes
bjorn3
bjorn3 reviewed Nov 17, 2025
View reviewed changes
bjorn3
bjorn3 approved these changes Nov 17, 2025
View reviewed changes
Copy link
Collaborator

@bjorn3 bjorn3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't say I understand exactly how the CRC32 implementation works, but if it produces correct results for a bunch of cases, it is probably correct.

@folkertdev folkertdev merged commit 7701dd3 into main Nov 17, 2025
26 checks passed
@folkertdev folkertdev deleted the crc32-updates branch November 17, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjorn3 bjorn3 bjorn3 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@folkertdev @bjorn3