add specific tests for copy_match
#188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
68a1ad0 to
282b316
Compare
folkertdev
commented
Sep 19, 2024
Comment on lines
+179
to
+181
| let ptr = buf.as_mut_ptr(); | ||
| unsafe { | ||
| Self::copy_chunk_unchecked::<C>( | ||
| buf.as_ptr().add(start), | ||
| buf.as_mut_ptr().add(current), | ||
| buf.as_ptr().add(end), | ||
| ) | ||
| Self::copy_chunk_unchecked::<C>(ptr.add(start), ptr.add(current), ptr.add(end)) |
Member
Author
There was a problem hiding this comment.
it is against miri rules to use the as_ptr to read from something modified by the as_mut_ptr. This is easily fixed by basing all pointers off of the mutable pointer. Because of subtyping, the mut is degrated to const when the type signatures demand it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.