这是indexloc提供的服务，不要输入任何密码
Skip to content

fix: allow custom min width for select components #952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
May 19, 2024
Merged

fix: allow custom min width for select components #952

merged 14 commits into from
May 19, 2024

Conversation

@mbauchet
Copy link
Collaborator

@mbauchet mbauchet commented Feb 8, 2024

Description
Moving className prop to the parent div wrapper instead of Listbox

Related issue(s)
#951

What kind of change does this PR introduce? (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • New Feature (BREAKING CHANGE which adds functionality)
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

How has this been tested?

Screenshots (if appropriate):

The PR fulfils these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the related issue section above
  • My change requires a change to the documentation. (Managed by Tremor Team)
  • I have added tests to cover my changes
  • Check the "Allow edits from maintainers" option while creating your PR.
  • Add refs #XXX or fixes #XXX to the related issue section if your PR refers to or fixes an issue.
  • By contributing to Tremor, you confirm that you have read and agreed to Tremor's CONTRIBUTING.md guideline. You also agree that your contributions will be licensed under the Apache License 2.0 license.

@vercel
Copy link

vercel bot commented Feb 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tremor-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2024 5:25pm

@severinlandolt severinlandolt changed the base branch from main to beta-dual-axis April 19, 2024 20:24
@severinlandolt severinlandolt added the PR: In Review This PR is in the process of being reviewed by the team label Apr 19, 2024
@severinlandolt severinlandolt changed the base branch from beta-dual-axis to beta May 19, 2024 17:18
@severinlandolt severinlandolt linked an issue May 19, 2024 that may be closed by this pull request
[Bug]: Hard-coded min-width on <Select> #951
Closed
@severinlandolt severinlandolt merged commit ded171b into tremorlabs:beta May 19, 2024
@github-actions
Copy link

github-actions bot commented May 19, 2024

🎉 This PR is included in version 3.16.3-beta.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

severinlandolt added a commit that referenced this pull request May 19, 2024
@severinlandolt @mbauchet @lcandy2
feat: New Axis labels, updated Barlist and CategoryBar (#1050)
55ecc3e 
* fix: allow custom min width for select components (#952)

* feat: add new sortorder option (#1048)

* fix: remove autocomplete

* fix: tab colors

* feat: chart axis labels (#1049)

* fix: barlist name type

* feat: CategoryBar tests for values more than 100 or less than 100

---------

Co-authored-by: severinlandolt <sev.landolt@gmail.com>
Co-authored-by: mbauchet <90607026+mbauchet@users.noreply.github.com>
Co-authored-by: Maxime BAUCHET <maxime.bauchet@insystem.fr>
Co-authored-by: 甜檸Cirtron <45784494+lcandy2@users.noreply.github.com>
@ZeroXClem ZeroXClem mentioned this pull request Aug 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@severinlandolt severinlandolt severinlandolt approved these changes

Assignees

No one assigned

Labels

PR: In Review This PR is in the process of being reviewed by the team released on @beta

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Hard-coded min-width on <Select>

2 participants

@mbauchet @severinlandolt