这是indexloc提供的服务，不要输入任何密码
Skip to content

feat: add new sortOrder option none #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2024
Merged

feat: add new sortOrder option none #1048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/components/vis-elements/BarList/BarList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export interface BarListProps<T = any> extends React.HTMLAttributes<HTMLDivEleme
color?: Color;
showAnimation?: boolean;
onValueChange?: (payload: Bar<T>) => void;
sortOrder?: "ascending" | "descending";
sortOrder?: "ascending" | "descending" | "none";
}

function BarListInner<T>(props: BarListProps<T>, ref: React.ForwardedRef<HTMLDivElement>) {
Expand All @@ -46,12 +46,12 @@ function BarListInner<T>(props: BarListProps<T>, ref: React.ForwardedRef<HTMLDiv

const Component = onValueChange ? "button" : "div";
const sortedData = React.useMemo(() => {
if (sortOrder) {
return [...data].sort((a, b) => {
return sortOrder === "ascending" ? a.value - b.value : b.value - a.value;
});
if (sortOrder === "none") {
return data;
}
return data;
return [...data].sort((a, b) => {
return sortOrder === "ascending" ? a.value - b.value : b.value - a.value;
});
}, [data, sortOrder]);

const widths = React.useMemo(() => {
Expand Down
27 changes: 25 additions & 2 deletions src/stories/vis-elements/BarList.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ const getData = (
additionalItems: BarListProps["data"] = [],
) => {
const basicData = [
{ name: "/home", value: 100000000 },
{ name: "/imprint", value: 351 },
{ name: "/home", value: 10000 },
{ name: "/cancellation", value: 271 },
{ name: "/imprint", value: 3351 },
{
name: `/special-offer-august-getsahdkjhagskdfjhgakshjgdfkjahsgdfjkgasdjkhfgajkshgdfjkhagsdkjhfgajhksdgfjkhasdg
fjkhagsdjhkgfasjkdgfjkasdhgkjgfdsk`,
Expand Down Expand Up @@ -92,3 +92,26 @@ export const WithOnValueChange: Story = {
onValueChange: (data) => alert(JSON.stringify(data)),
},
};

export const SortOrderDescending: Story = {
render: (args) => <BarList {...args} />,
args: {
data: getData(),
},
};

export const SortOrderAscending: Story = {
render: (args) => <BarList {...args} />,
args: {
data: getData(),
sortOrder: "ascending",
},
};

export const SortOrderNone: Story = {
render: (args) => <BarList {...args} />,
args: {
data: getData(),
sortOrder: "none",
},
};