Fix for USB Microphones as external device #504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing if (length < 3000) check fixes the issue because it ensures small buffers are not prematurely discarded. The original check was likely added with a misguided assumption that small buffers are insignificant, but this breaks microphone functionality where small buffers are common.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing
if (length < 3000)check fixes the issue because it ensures small buffers are not prematurely discarded.Microphones, especially USB ones, often use smaller buffer sizes to provide low-latency audio. The 3000 threshold was prematurely skipping the processing of these small buffers, essentially discarding the input entirely.