fix: prevent uiscale from being zero #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When entering a uiscale, if the user starts with '0' or '.', Tooll will parse it as a 0, and the UI will break immediately (the field lose the focus, it can't be edited anymore, the 0 value is saved to userSettings and has to be fixed manually there) This patch prevent such situation from happening by forcing it back to some minimal value when it get to close to zero and let the edit happen entirely. |
pixtur
requested changes
Jan 11, 2024
Co-authored-by: Thomas Mann <thomas.mann@framefield.com>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.