这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@trillium
Copy link
Contributor

Enhancement

Current mobile drawer doesn't take advantage of accessibility offered by headlessui

Used headlessui/Dialog as an example to refactor the MobileNav drawer

Changes

  • Move close button to bottom of drawer HTML so it is not auto selected when entering MobileNav
  • Kept current MobileNav styling
  • Changed to Dialog as base component
    • Allows for tab press to stay within Dialog
    • Allows for esc press to close Dialog

Visuals

Before Changes image image
After Changes image image

@vercel
Copy link

vercel bot commented Jun 19, 2024

@spiteless is attempting to deploy a commit to the timlrx's projects Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Jun 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tailwind-nextjs-starter-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2024 8:23am

@timlrx
Copy link
Owner

timlrx commented Jun 22, 2024

Resolved merge conflict by adding some of the changes from the previous PR. Otherwise the changes looks good to me. Now that we are using headlessui for the theme switch component, I think this change makes sense and the accessibility improvement is great.

@timlrx timlrx merged commit d81f28b into timlrx:main Jun 22, 2024
bhiwagade-rahul pushed a commit to bhiwagade-rahul/tailwind-nextjs-starter-blog that referenced this pull request Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants