这是indexloc提供的服务，不要输入任何密码
Skip to content

fix: insert code title relative to parent #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 26, 2022
Merged

fix: insert code title relative to parent #359

merged 1 commit into from
Jan 26, 2022
+2 −2

Conversation

@timlrx
Copy link
Owner

@timlrx timlrx commented Jan 26, 2022 •
edited
Loading

Fix timlrx/rehype-prism-plus#29

Code title should be inserted relative to the parent, not the root component as it may be a child itself e.g.

<div style={{height: '300px', overflow: 'scroll'}}>
```json:fileName.json
A very long code snippet
```
</div>

@vercel
Copy link

vercel bot commented Jan 26, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/timlrx/tailwind-nextjs-starter-blog/FSS5j9qkGvNYpTLnSopmDLpJ4pDV
✅ Preview: https://tailwind-nextjs-starter-blog-git-fix-code-titles-timlrx.vercel.app

@timlrx timlrx merged commit f91793a into master Jan 26, 2022
@timlrx
Copy link
Owner Author

timlrx commented Jan 26, 2022

@AlexanderZeilmann this should fix the issue.

@AlexanderZeilmann
Copy link
Contributor

AlexanderZeilmann commented Jan 26, 2022

I can confirm this fixes it.

@timlrx timlrx deleted the fix/code-titles branch February 6, 2022 13:12
Meez25 pushed a commit to Meez25/Blog that referenced this pull request Jun 17, 2024
@timlrx
Merge pull request timlrx#359 from timlrx/fix/code-titles
411878d 
fix: insert code title relative to parent
bhiwagade-rahul pushed a commit to bhiwagade-rahul/tailwind-nextjs-starter-blog that referenced this pull request Sep 22, 2025
@timlrx
Merge pull request timlrx#359 from timlrx/fix/code-titles
823fbbf 
fix: insert code title relative to parent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Wrapping code snippets in a div puts the code title at a wrong position

3 participants

@timlrx @AlexanderZeilmann