-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Add rehype-preset-minify #333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Someone is attempting to deploy a commit to a Personal Account owned by @timlrx on Vercel. @timlrx first needs to authorize it. |
|
There's no need for the plugin as both esbuild which is used by mdx-bundler and webpack / swc from nextjs will take care of it. It's intended for use in standalone applications. |
|
Adding the plugin does have an effect (-> right-click -> view source): esbuild / webpack / swc do minify the page but not the blog post. |
|
Thanks, good to know. Can we try turning on the minify option in |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/timlrx/tailwind-nextjs-starter-blog/4Qnsz6iaE9KVCatzMFA3BATnHp38 |
|
I'm not seeing any minification when using |
|
Took a deeper look into this issue. Mdx-bundler sets minify to true by default. Changing it to false does show a difference. The output from xdm is probably treated by esbuild as a string literal and it does not minify it. Hence the plugin is required, if we truly want to minimize the size of HTML over the wire. It seems to be relatively minor about 6% smaller and am not too sure how much longer it takes to process but happy to merge in the change. Thanks! |
feat: Add rehype-preset-minify
feat: Add rehype-preset-minify
This allows the minification of blog posts.