-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
fix: can not load external script & Unable to get disqus config of shorname #308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: can not load external script & Unable to get disqus config of shorname #308
Conversation
|
Someone is attempting to deploy a commit to a Personal Account owned by @timlrx on Vercel. @timlrx first needs to authorize it. |
|
Ahh right, I forgot them, sorry 🙈 |
I have updated the whitelist, thank you for your contribution 🍻 |
|
I just figured out that we do not have to put |
|
I preference would be to only add |
I agree with you, although this will affect the user experience, because we are hard to dynamically generate CSP, so we agree to only add |
|
Yes, this was also discussed in the issue by Alexander. There's a bit of trade-off between having a better default security practice vs ease of setting up the template. |
ed38e22 to
f62ff2d
Compare
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/timlrx/tailwind-nextjs-starter-blog/Ebf2bNNZMAhv4KKxrfo9i9QMcehE |
…-script fix: can not load external script & Unable to get disqus config of shorname
…-script fix: can not load external script & Unable to get disqus config of shorname
Fix unable to load external js (Google Analytics and comment function), because Content Security Policy did not add the above to the whitelist Add security headers - fixes #304 #307
Reproduce: https://tailwind-nextjs-starter-blog.vercel.app/blog/new-features-in-v1
Fix unable to get disqus config of shorname