这是indexloc提供的服务,不要输入任何密码
Skip to content

Do not check bounds since it is always valid when everything is fine. #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2020

Conversation

duburcqa
Copy link
Collaborator

@duburcqa duburcqa commented Jun 25, 2020

Avoid the overhead of checking bounds for subfields since it should be fine useless the user is messing up terribly somewhere else.

@Trinkle23897
Copy link
Collaborator

Simple solution, I like it!

@Trinkle23897
Copy link
Collaborator

Trinkle23897 commented Jun 25, 2020

Hmm... I didn't figure out what's the bottleneck. Still 8 mins per unittest.
The seed is fixed so that the training process would be exactly the same as the previous version.

@duburcqa
Copy link
Collaborator Author

duburcqa commented Jun 25, 2020

Do you have any idea how we could profile the code ? Perhaps Batch is supporting too many types, requiring many isinstance check for each of them. 8 minutes on your computer or github ? Because sometimes github slow down for some reason.

@Trinkle23897
Copy link
Collaborator

On GitHub. But in my computer, it is almost the same as previous. I'll open an issue about profiling Batch.

@Trinkle23897 Trinkle23897 merged commit 5ac9f9b into thu-ml:master Jun 25, 2020
This was linked to issues Jun 29, 2020
BFAnas pushed a commit to BFAnas/tianshou that referenced this pull request May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Batch & Buffer profiling Batch to Numpy compatibility
2 participants