Fix Batch to numpy compatibility #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e5e1772 to
1496e7f
Compare
3c41837 to
ba83e42
Compare
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
==========================================
- Coverage 85.36% 84.80% -0.56%
==========================================
Files 29 29
Lines 1783 1843 +60
==========================================
+ Hits 1522 1563 +41
- Misses 261 280 +19
Continue to review full report at Codecov.
|
BFAnas
pushed a commit
to BFAnas/tianshou
that referenced
this pull request
May 5, 2024
* Fix Batch to numpy compatibility. * Fix Batch unit tests. * Fix linter * Add Batch shape method. * Remove shape and add size. Enable to reserve keys using empty batch/list. * Fix linter and unit tests. * Batch init using list of Batch. * Add unit tests. * Fix Batch __len__. * Fix unit tests. * Fix slicing * Add missing slicing unit tests. Co-authored-by: Alexis Duburcq <alexis.duburcq@wandercraft.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Batchclass to behave similarly to numpy, especially regarding slicing and get lengthBatchcan now be initialized with a wide variety of argument types, making it very user friendly and intuitivenp.mean(Batch(...))and get the expected result. Incidently, it is also possible to dolist(Batch(...))to split a Batch, or loop over samples doingfor sample in Batch(...): ...sizemethod and modify__len__to behave similarly to numpyRelated to issue #90