-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Custom keys support in ReplayBuffer #903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #903 +/- ##
=======================================
Coverage 91.10% 91.10%
=======================================
Files 73 73
Lines 5102 5106 +4
=======================================
+ Hits 4648 4652 +4
Misses 454 454
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@@ -232,7 +232,7 @@ def add( | |||
""" | |||
# preprocess batch | |||
new_batch = Batch() | |||
for key in set(self._input_keys).intersection(batch.keys()): | |||
for key in batch.keys(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you change the above docstring accordingly? L223-L224 for example, not sure if there's any other place
Issue: Custom keys support in ReplayBuffer thu-ml#902 Modified `ReplayBuffer` `add` and `__getitem__` methods. Added `test_custom_key()` to test_buffer.py
make format
(required)make commit-checks
(required)Issue: Custom keys support in ReplayBuffer #902
Modified
ReplayBuffer
add
and__getitem__
methods.Added
test_custom_key()
to test_buffer.py