Batch refactoring #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@Trinkle23897 Ready to be merged if you are ok with the changes |
BFAnas
pushed a commit
to BFAnas/tianshou
that referenced
this pull request
May 5, 2024
* Enable to stack Batch instances. Add Batch cat static method. Rename cat in cat_ since inplace. * Properly handle Batch init using np.array of dict. * WIP * Get rid of metadata. * Update UT. Replace cat by cat_ everywhere. * Do not sort Batch keys anymore for efficiency. Add items method. * Fix cat copy issue. * Add unit test to chack cat and stack methods. * Remove used import. * Fix linter issues. * Fix unit tests. Co-authored-by: Alexis Duburcq <alexis.duburcq@wandercraft.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_meta, which simplifies and clarifies the implementationBatchinstance using adictinstead of individual keys only, simular to Pythondictitself orgym.spaces.Dictnp.arrayBatchkeys anymore for efficiency. Additemsmethod. Now it mimics completely the behavior of nativedictcatincat_and addcatmethod for consistency with in-place / out-of-place torch APIstackmethod, which is equivalent to torch/numpystackmethod (It adds an extra dimension)Batch/dict. 0-dimnp.arraymust be used to get a 1-dimnp.arrayafter Batch stacking.