这是indexloc提供的服务,不要输入任何密码
Skip to content

Add "act" to preprocess_fn call in collector. #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jamartinh
Copy link
Contributor

This allows, for instance, to change the action registered into the buffer when the environment modify the action.

Useful in offline learning for instance, since the true actions are in a dataset and the actions of the agent are ignored.

  • I have marked all applicable categories:
    • exception-raising fix
    • algorithm implementation fix
    • documentation modification
    • new feature
  • [X ] I have reformatted the code using make format (required)
  • I have checked the code using make commit-checks (required)
  • [] If applicable, I have mentioned the relevant/related issue(s)
  • If applicable, I have listed every items in this Pull Request below

…ce to change the action registered into the buffer when the environment modify the action. (useful in offline learning for instance,since the true actions are in a dataset and the actions of the agent are ignored)
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2023

Codecov Report

Merging #801 (bdb11d8) into master (774d3d8) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master     #801   +/-   ##
=======================================
  Coverage   90.89%   90.89%           
=======================================
  Files          73       73           
  Lines        5109     5109           
=======================================
  Hits         4644     4644           
  Misses        465      465           
Flag Coverage Δ
unittests 90.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tianshou/data/collector.py 90.30% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

…nce to change the action registered into the buffer when the environment modify the action. (useful in offline learning for instance,since the true actions are in a dataset and the actions of the agent are ignored)
@Trinkle23897 Trinkle23897 merged commit 6019406 into thu-ml:master Feb 3, 2023
@jamartinh jamartinh deleted the collector_preprocess_fn_call_with_act branch March 23, 2023 08:33
BFAnas pushed a commit to BFAnas/tianshou that referenced this pull request May 5, 2024
This allows, for instance, to change the action registered into the
buffer when the environment modify the action.

Useful in offline learning for instance, since the true actions are in a
dataset and the actions of the agent are ignored.

- [ ] I have marked all applicable categories:
    + [ ] exception-raising fix
    + [ ] algorithm implementation fix
    + [ ] documentation modification
    + [X] new feature
- [X ] I have reformatted the code using `make format` (**required**)
- [X] I have checked the code using `make commit-checks` (**required**)
- [] If applicable, I have mentioned the relevant/related issue(s)
- [X] If applicable, I have listed every items in this Pull Request
below
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants