这是indexloc提供的服务，不要输入任何密码
Skip to content

W&B: Add usage in the docs #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 13, 2021
Merged

W&B: Add usage in the docs #463

merged 4 commits into from
Oct 13, 2021

Conversation

AyushExel
Copy link
Contributor

@AyushExel AyushExel commented Oct 7, 2021 •
edited
Loading

  • I have marked all applicable categories:
    • exception-raising fix
    • algorithm implementation fix
    • documentation modification
    • new feature
  • I have reformatted the code using make format (required)
  • I have checked the code using make commit-checks (required)
  • If applicable, I have mentioned the relevant/related issue(s)
  • If applicable, I have listed every items in this Pull Request below

@Trinkle23897 I've added the usage in the docs. Can you also add something in the readme along with tensorboardLogger?

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2021 •
edited
Loading

Codecov Report

Merging #463 (8a75d63) into master (926ec0b) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #463      +/-   ##
==========================================
- Coverage   94.12%   94.05%   -0.08%     
==========================================
  Files          60       60              
  Lines        3883     3883              
==========================================
- Hits         3655     3652       -3     
- Misses        228      231       +3
Flag Coverage Δ
unittests 94.05% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tianshou/policy/modelfree/npg.py 97.70% <0.00%> (-1.15%) ⬇️
tianshou/data/collector.py 94.75% <0.00%> (-0.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 926ec0b...8a75d63. Read the comment docs.

@Trinkle23897
Copy link
Collaborator

Can you also add something in the readme along with tensorboardLogger?

Could you please give me some suggestions?

@AyushExel
Copy link
Contributor Author

Can you also add something in the readme along with tensorboardLogger?

Could you please give me some suggestions?

After define hyperparameters section, you could add a Logging section which shows example of initializing both WandbLogger and TensorboardLogger

@Trinkle23897
Copy link
Collaborator

Trinkle23897 commented Oct 8, 2021 •
edited
Loading

I'll try to make it. (Before Saturday... I have a paper submission deadline today)

@AyushExel
Copy link
Contributor Author

@Trinkle23897 Sure. There is no rush. Please take your time.

@Trinkle23897 Trinkle23897 merged commit 63d752e into thu-ml:master Oct 13, 2021
BFAnas pushed a commit to BFAnas/tianshou that referenced this pull request May 5, 2024
@AyushExel
W&B: Add usage in the docs (thu-ml#463)
d5988ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trinkle23897 Trinkle23897 Trinkle23897 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AyushExel @codecov-commenter @Trinkle23897