这是indexloc提供的服务，不要输入任何密码
Skip to content

pettingzoo wrapper #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

pettingzoo wrapper #447

wants to merge 7 commits into from

Conversation

rodrigodelazcano
Copy link
Contributor

  • I have marked all applicable categories:
    • exception-raising fix
    • algorithm implementation fix
    • documentation modification
    • new feature
  • I have reformatted the code using make format (required)
  • I have checked the code using make commit-checks (required)
  • If applicable, I have mentioned the relevant/related issue(s)
  • If applicable, I have listed every items in this Pull Request below

PR to follow the issue #446

@rodrigodelazcano rodrigodelazcano mentioned this pull request Sep 11, 2021
Closed
8 tasks
@jkterry1
Copy link
Contributor

@Trinkle23897 could you please approve tests? I'm trying to fix the more obvious failures

@jkterry1
Copy link
Contributor

@Trinkle23897 could you please approve again?

@mahi97
Copy link
Contributor

mahi97 commented Dec 14, 2021 •
edited
Loading

I wondered whether this PR want to change tianshou so it only works with pettingzoo environments for multi-agent or we want to keep the support of tianshou.MultiAgentEnv too?

Current changes in MultiAgentPolicyManager remove the support for tianshou.MultiAgentEnv, and that is the reason the tests are failing.

@jkterry1
Copy link
Contributor

My preference would be to specifically work for pettingzoo environments, its a pretty widely used standard (over 30 third party environments and like a dozen learning libraries use it as their primary API)

@mahi97
Copy link
Contributor

mahi97 commented Dec 16, 2021

I think the pettingzoo wrapper is ready to be used.
Should I open a new PR for this repository or rodrigodelazcano:pettingzoo?

@Trinkle23897
Copy link
Collaborator

Trinkle23897 commented Dec 16, 2021 •
edited
Loading

My preference would be to specifically work for pettingzoo environments

Agree!

Should I open a new PR for this repository or rodrigodelazcano:pettingzoo?

I prefer the former.

@mahi97
Copy link
Contributor

mahi97 commented Dec 16, 2021

Ok, sure, I opened a new one: #494 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rodrigodelazcano @jkterry1 @mahi97 @Trinkle23897