这是indexloc提供的服务，不要输入任何密码
Skip to content

fix dual clip implementation #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2021
Merged

fix dual clip implementation #435

merged 1 commit into from
Sep 2, 2021

Conversation

Ending2015a
Copy link
Contributor

@Ending2015a Ending2015a commented Sep 2, 2021 •
edited
Loading

  • have marked all applicable categories:
    • exception-raising fix
    • algorithm implementation fix
    • documentation modification
    • new feature
  • If applicable, I have mentioned the relevant/related issue(s)

Less important but also useful:

  • I have visited the source website
  • I have searched through the issue tracker for duplicates
  • I have mentioned version numbers, operating system and environment, where applicable: 
    import tianshou, torch, numpy, sys
print(tianshou.__version__, torch.__version__, numpy.__version__, sys.version, sys.platform)

Fix issue #433

@Trinkle23897 Trinkle23897 linked an issue Sep 2, 2021 that may be closed by this pull request
A bug about dual clip PPO implementation #433
Closed
8 tasks
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2021 •
edited
Loading

Codecov Report

Merging #435 (3ed8c77) into master (8a5e219) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #435      +/-   ##
==========================================
- Coverage   94.76%   94.71%   -0.05%     
==========================================
  Files          60       60              
  Lines        3820     3822       +2     
==========================================
  Hits         3620     3620              
- Misses        200      202       +2
Flag Coverage Δ
unittests 94.71% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tianshou/policy/modelfree/ppo.py 91.17% <0.00%> (-2.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a5e219...3ed8c77. Read the comment docs.

@Trinkle23897 Trinkle23897 merged commit a740496 into thu-ml:master Sep 2, 2021
BFAnas pushed a commit to BFAnas/tianshou that referenced this pull request May 5, 2024
@Ending2015a
fix dual clip implementation (thu-ml#435)
aaf58ef 
close thu-ml#433
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trinkle23897 Trinkle23897 Trinkle23897 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A bug about dual clip PPO implementation
3 participants
@Ending2015a @codecov-commenter @Trinkle23897