support observation normalization in BaseVectorEnv #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #308 +/- ##
==========================================
- Coverage 94.00% 93.37% -0.64%
==========================================
Files 51 51
Lines 3238 3277 +39
==========================================
+ Hits 3044 3060 +16
- Misses 194 217 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
danagi
approved these changes
Mar 11, 2021
|
One thing to do is how do we save rms(obseravtion mean and std) since it is a part of policy? We can leave this problem till next pr or when we need this anyway |
|
I'm okay with changes. |
BFAnas
pushed a commit
to BFAnas/tianshou
that referenced
this pull request
May 5, 2024
add RunningMeanStd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr aims to support observation normalization in BaseVectorEnv because it's crucial for benmarking on policy algoirthms. See #307 for more details.