Improve buffer.prev() & buffer.next() #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #294 +/- ##
==========================================
- Coverage 94.51% 93.90% -0.61%
==========================================
Files 45 45
Lines 3152 3185 +33
==========================================
+ Hits 2979 2991 +12
- Misses 173 194 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Trinkle23897
commented
Feb 20, 2021
|
I prefer unfinished index over last_index. |
ChenDRAG
approved these changes
Feb 22, 2021
Trinkle23897
added a commit
that referenced
this pull request
Feb 22, 2021
BFAnas
pushed a commit
to BFAnas/tianshou
that referenced
this pull request
May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typically in atari training pipeline, buf.prev takes over 30% time. This pr aims to optimize buffer.prev/next: use njit to make it faster.