Add Timelimit trick to optimize policies #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #296 +/- ##
=======================================
Coverage 93.89% 93.89%
=======================================
Files 47 47
Lines 3241 3241
=======================================
Hits 3043 3043
Misses 198 198
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
2301bd0 to
54b4cb6
Compare
|
Ready, I think |
Trinkle23897
approved these changes
Feb 26, 2021
BFAnas
pushed a commit
to BFAnas/tianshou
that referenced
this pull request
May 5, 2024
* consider timelimit.truncated in calculating returns by default * remove ignore_done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the 5th commit of 6 commits mentioned in #274. You can check #274 for more detail.