fix 2 bugs of batch #284
Merged
fix 2 bugs of batch #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duburcqa
reviewed
Feb 2, 2021
duburcqa
approved these changes
Feb 2, 2021
Merged
Trinkle23897
added a commit
that referenced
this pull request
Feb 16, 2021
1. `_create_value(Batch(a={}, b=[1, 2, 3]), 10, False)`
before:
```python
TypeError: cannot concatenate with Batch() which is scalar
```
after:
```python
Batch(
a: Batch(),
b: array([0, 0, 0, 0, 0, 0, 0, 0, 0, 0]),
)
```
2. creating keys in a batch's subkey, e.g.
```python
a = Batch(info={"key1": [0, 1], "key2": [2, 3]})
a[0] = Batch(info={"key1": 2, "key3": 4})
print(a)
```
before:
```python
Batch(
info: Batch(
key1: array([0, 1]),
key2: array([0, 3]),
),
)
```
after:
```python
ValueError: Creating keys is not supported by item assignment.
```
3. small optimization for `Batch.stack_` and `Batch.cat_`
BFAnas
pushed a commit
to BFAnas/tianshou
that referenced
this pull request
May 5, 2024
1. `_create_value(Batch(a={}, b=[1, 2, 3]), 10, False)`
before:
```python
TypeError: cannot concatenate with Batch() which is scalar
```
after:
```python
Batch(
a: Batch(),
b: array([0, 0, 0, 0, 0, 0, 0, 0, 0, 0]),
)
```
2. creating keys in a batch's subkey, e.g.
```python
a = Batch(info={"key1": [0, 1], "key2": [2, 3]})
a[0] = Batch(info={"key1": 2, "key3": 4})
print(a)
```
before:
```python
Batch(
info: Batch(
key1: array([0, 1]),
key2: array([0, 3]),
),
)
```
after:
```python
ValueError: Creating keys is not supported by item assignment.
```
3. small optimization for `Batch.stack_` and `Batch.cat_`, raise ValueError when receiving invalid data format.
BFAnas
pushed a commit
to BFAnas/tianshou
that referenced
this pull request
May 5, 2024
1. `_create_value(Batch(a={}, b=[1, 2, 3]), 10, False)`
before:
```python
TypeError: cannot concatenate with Batch() which is scalar
```
after:
```python
Batch(
a: Batch(),
b: array([0, 0, 0, 0, 0, 0, 0, 0, 0, 0]),
)
```
2. creating keys in a batch's subkey, e.g.
```python
a = Batch(info={"key1": [0, 1], "key2": [2, 3]})
a[0] = Batch(info={"key1": 2, "key3": 4})
print(a)
```
before:
```python
Batch(
info: Batch(
key1: array([0, 1]),
key2: array([0, 3]),
),
)
```
after:
```python
ValueError: Creating keys is not supported by item assignment.
```
3. small optimization for `Batch.stack_` and `Batch.cat_`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_create_value(Batch(a={}, b=[1, 2, 3]), 10, False)before:
after:
before:
after:
Batch.stack_andBatch.cat_