这是indexloc提供的服务,不要输入任何密码
Skip to content

update utils.network #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jan 20, 2021
Merged

update utils.network #275

merged 16 commits into from
Jan 20, 2021

Conversation

ChenDRAG
Copy link
Collaborator

@ChenDRAG ChenDRAG commented Jan 18, 2021

This is the first commit of 6 commits mentioned in #274, which features

  1. Refactor of Class Net to support any form of MLP.
  2. Enable type check in utils.network.
  3. Relative change in docs/test/examples.
  4. Move atari-related network to examples/atari/atari_network.py

@Trinkle23897 Trinkle23897 changed the title pep8 fix update utils.network Jan 18, 2021
@codecov-io
Copy link

codecov-io commented Jan 18, 2021

Codecov Report

Merging #275 (d9f608d) into master (866e35d) will decrease coverage by 0.14%.
The diff coverage is 91.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #275      +/-   ##
==========================================
- Coverage   94.24%   94.09%   -0.15%     
==========================================
  Files          42       42              
  Lines        2763     2762       -1     
==========================================
- Hits         2604     2599       -5     
- Misses        159      163       +4     
Flag Coverage Δ
unittests 94.09% <91.11%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tianshou/utils/net/common.py 93.61% <89.47%> (-3.72%) ⬇️
tianshou/utils/net/continuous.py 95.49% <91.66%> (+0.25%) ⬆️
tianshou/utils/net/discrete.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 866e35d...d9f608d. Read the comment docs.

@Trinkle23897
Copy link
Collaborator

Broken support yet, I'll fix them tmr

@Trinkle23897
Copy link
Collaborator

ready now

@Trinkle23897 Trinkle23897 requested a review from duburcqa January 19, 2021 12:38
@Trinkle23897 Trinkle23897 merged commit a633a6a into thu-ml:master Jan 20, 2021
ChenDRAG added a commit to ChenDRAG/tianshou that referenced this pull request Jan 20, 2021
@Trinkle23897 Trinkle23897 linked an issue Apr 21, 2021 that may be closed by this pull request
BFAnas pushed a commit to BFAnas/tianshou that referenced this pull request May 5, 2024
This is the first commit of 6 commits mentioned in thu-ml#274, which features

1. Refactor of `Class Net` to support any form of MLP.
2. Enable type check in utils.network.
3. Relative change in docs/test/examples.
4. Move atari-related network to examples/atari/atari_network.py

Co-authored-by: Trinkle23897 <trinkle23897@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plans of releasing mujoco benchmark with ddpg/sac/td3 on Tianshou
4 participants