code format and update function signatures #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trinkle23897
commented
Sep 12, 2020
Trinkle23897
commented
Sep 12, 2020
Codecov Report
@@ Coverage Diff @@
## master #213 +/- ##
==========================================
+ Coverage 94.10% 94.16% +0.05%
==========================================
Files 39 38 -1
Lines 2443 2450 +7
==========================================
+ Hits 2299 2307 +8
+ Misses 144 143 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Trinkle23897
commented
Sep 12, 2020
duburcqa
previously approved these changes
Sep 12, 2020
Collaborator
duburcqa
left a comment
There was a problem hiding this comment.
Not much to say about this PR in practice it changes nothing, but I can see that I don't like much the new formatting style x)
BFAnas
pushed a commit
to BFAnas/tianshou
that referenced
this pull request
May 5, 2024
Cherry-pick from thu-ml#200 - update the function signature - format code-style - move _compile into separate functions - fix a bug in to_torch and to_numpy (Batch) - remove None in action_range In short, the code-format only contains function-signature style and `'` -> `"`. (pick up from [black](https://github.com/psf/black))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick from #200
In short, the code-format only contains function-signature style and
'->". (pick up from black)