fix critical bugs in MAPolicy and docs update #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #207 +/- ##
==========================================
- Coverage 94.09% 93.60% -0.50%
==========================================
Files 40 40
Lines 2457 2454 -3
==========================================
- Hits 2312 2297 -15
- Misses 145 157 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
8 tasks
duburcqa
approved these changes
Sep 8, 2020
duburcqa
reviewed
Sep 8, 2020
| save_rew, buffer.rew = buffer.rew, Batch() | ||
| # Since we do not override buffer.__setattr__, here we use _meta to | ||
| # change buffer.rew, otherwise buffer.rew = Batch() has no effect. | ||
| save_rew, buffer._meta.rew = buffer.rew, Batch() |
There was a problem hiding this comment.
It would be nice to find a way to avoid such trick in future release because it is error prone.
BFAnas
pushed a commit
to BFAnas/tianshou
that referenced
this pull request
May 5, 2024
- fix a bug in MAPolicy: `buffer.rew = Batch()` doesn't change `buffer.rew` (thanks mypy) - polish examples/box2d/bipedal_hardcore_sac.py - several docs update - format setup.py and bump version to 0.2.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick from #200
buffer.rew = Batch()doesn't changebuffer.rew(thanks mypy)