set policy.eval() before collector.collect #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Codecov Report
@@ Coverage Diff @@
## master #204 +/- ##
=======================================
Coverage 94.13% 94.13%
=======================================
Files 40 40
Lines 2455 2455
=======================================
Hits 2311 2311
Misses 144 144
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
8 tasks
youkaichao
previously approved these changes
Sep 5, 2020
duburcqa
approved these changes
Sep 6, 2020
Leeqh666
added a commit
to Leeqh666/tianshou
that referenced
this pull request
Sep 6, 2020
set policy.eval() before collector.collect (thu-ml#204)
Trinkle23897
added a commit
to danagi/tianshou
that referenced
this pull request
Sep 11, 2020
Trinkle23897
added a commit
that referenced
this pull request
Sep 12, 2020
9 tasks
BFAnas
pushed a commit
to BFAnas/tianshou
that referenced
this pull request
May 5, 2024
* fix thu-ml#203 * no_grad argument in collector.collect
BFAnas
pushed a commit
to BFAnas/tianshou
that referenced
this pull request
May 5, 2024
- replace DiagGuassian with Independent(Normal) (pytorch has already supported this) - detach alpha from autograd - add value/alpha to result (more informational) - revert thu-ml#204 to fix thu-ml#211 Co-authored-by: Trinkle23897 <463003665@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.