add policy.update to enable post process and remove collector.sample #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #180 +/- ##
==========================================
+ Coverage 88.74% 89.14% +0.39%
==========================================
Files 39 39
Lines 2399 2404 +5
==========================================
+ Hits 2129 2143 +14
+ Misses 270 261 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Trinkle23897
reviewed
Aug 6, 2020
1d1c120 to
2fb5a1c
Compare
|
This PR is much simpler. Have a look when you are available! @Trinkle23897 @duburcqa |
|
The following code snippets should be changed since collector.sample has been removed: $ grep collector.sample * -r
docs/tutorials/dqn.rst: losses = policy.learn(train_collector.sample(batch_size=64))
docs/tutorials/concepts.rst: b_s, b_a, b_s_, b_r, b_d = buffer.get(size=64) # collector.sample(batch_size)
README.md:result = policy.learn(collector.sample(batch_size)) |
duburcqa
reviewed
Aug 11, 2020
duburcqa
reviewed
Aug 11, 2020
duburcqa
reviewed
Aug 11, 2020
duburcqa
previously approved these changes
Aug 11, 2020
8 tasks
just a test
|
How do you do suggestions ?? That's a nice feature 👍 |
|
Trinkle23897
previously approved these changes
Aug 11, 2020
youkaichao
commented
Aug 12, 2020
Trinkle23897
approved these changes
Aug 12, 2020
BFAnas
pushed a commit
to BFAnas/tianshou
that referenced
this pull request
May 5, 2024
…hu-ml#180) * add policy.update to enable post process and remove collector.sample * update doc in policy concept * remove collector.sample in doc * doc update of concepts * docs * polish * polish policy * remove collector.sample in docs * minor fix * Apply suggestions from code review just a test * doc fix Co-authored-by: Trinkle23897 <463003665@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reply to this comment.