Replay buffer allows stack_num = 1 #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trinkle23897
approved these changes
Jul 25, 2020
youkaichao
approved these changes
Jul 25, 2020
|
Nice little pr to resolve the legacy inconsistency 👍 Maybe this should be mentioned in release notes. |
BFAnas
pushed a commit
to BFAnas/tianshou
that referenced
this pull request
May 5, 2024
* stack_num starts at 1 (for no stacking) instead of 0. * Use getter/stepper for stack_num. Co-authored-by: Alexis Duburcq <alexis.duburcq@wandercraft.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it is more convenient to consider "no stacking" = 1 instead of 0, as it is the case now. It is useful in my case because it enables to increase number of observation steps provided to the model without having to do an exception for "no stack" case.