move atari wrapper to examples and publish v0.2.4 #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duburcqa
reviewed
Jul 10, 2020
|
I think it is time to publish v0.2.4. |
duburcqa
approved these changes
Jul 10, 2020
|
I guess you are right (maybe specify it in the PR message). |
BFAnas
pushed a commit
to BFAnas/tianshou
that referenced
this pull request
May 5, 2024
* move atari wrapper to examples * consistency * change drqn seed since it is quite unstable in current seed * minor fix * 0.2.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove atari wrapper inside core. Move it to
examples/. It is @Mehooz 's work.I also change the seed in test_drqn. In our local test, test_drqn behaves normally as before but in GitHub Actions it seems quite unstable under previous seed.