Lower level access to hl world #1187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1187 +/- ##
==========================================
- Coverage 85.66% 85.51% -0.15%
==========================================
Files 104 104
Lines 8834 8874 +40
==========================================
+ Hits 7568 7589 +21
- Misses 1266 1285 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
98cbce8 to
6b4df50
Compare
opcode81
reviewed
Aug 5, 2024
opcode81
reviewed
Aug 5, 2024
opcode81
reviewed
Aug 5, 2024
opcode81
reviewed
Aug 5, 2024
opcode81
reviewed
Aug 5, 2024
Moved handling of `start_timesteps` from AgentFactory to Experiment.run. Slight internal simplifications, extended documentation
Also minor aesthetic changes
3bc607e to
4acdac7
Compare
|
Was reviewed in pair programming and in conversation above, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives the user the possibility to extract the
Worldfrom a configuredExperiment. This required moving the initial rollout (according tostart_timesteps) from theAgentFactorytoExperiment.run. But since it was only ever used there, this change is essentially backwards compatibleI also enhanced documentation.
__init__docstrings were previously not rendered and there were some formatting errors in them, hence the changes there.