这是indexloc提供的服务，不要输入任何密码
Skip to content

Improve interface of BasePolicy.compute_action #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 18, 2024
Merged

Improve interface of BasePolicy.compute_action #1170

merged 2 commits into from
Jul 18, 2024

Conversation

opcode81
Copy link
Collaborator

@opcode81 opcode81 commented Jul 8, 2024

  • I have added the correct label(s) to this Pull Request or linked the relevant issue(s)
  • I have provided a description of the changes in this Pull Request
  • I have added documentation for my changes and have listed relevant changes in CHANGELOG.md
  • If applicable, I have added tests to cover my changes.
  • I have reformatted the code using poe format
  • I have checked style and types with poe lint and poe type-check
  • (Optional) I ran tests locally with poe test
    (or a subset of them with poe test-reduced) ,and they pass
  • (Optional) I have tested that documentation builds correctly with poe doc-build

Implements #1169

@opcode81 opcode81 added the enhancement Feature that is not a new algorithm or an algorithm enhancement label Jul 8, 2024
@opcode81 opcode81 force-pushed the improve-compute-action branch 2 times, most recently from 3c52d43 to 340823e Compare July 8, 2024 12:05
@opcode81 opcode81 requested a review from MischaPanch July 8, 2024 12:10
@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.73%. Comparing base (9362744) to head (408f052).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1170   +/-   ##
=======================================
  Coverage   85.73%   85.73%           
=======================================
  Files         104      104           
  Lines        8719     8721    +2     
=======================================
+ Hits         7475     7477    +2     
  Misses       1244     1244
Flag Coverage Δ
unittests 85.73% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@opcode81 opcode81 force-pushed the improve-compute-action branch from 340823e to 408f052 Compare July 8, 2024 13:29
Trinkle23897
Trinkle23897 reviewed Jul 8, 2024
View reviewed changes
@MischaPanch MischaPanch enabled auto-merge (squash) July 18, 2024 19:10
@MischaPanch MischaPanch disabled auto-merge July 18, 2024 19:23
@MischaPanch MischaPanch merged commit 7a4e5f1 into master Jul 18, 2024
8 checks passed
@MischaPanch MischaPanch deleted the improve-compute-action branch July 18, 2024 19:23
@MischaPanch MischaPanch mentioned this pull request Jul 18, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trinkle23897 Trinkle23897 Trinkle23897 left review comments

@MischaPanch MischaPanch MischaPanch approved these changes

Assignees
No one assigned
Labels
enhancement Feature that is not a new algorithm or an algorithm enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@opcode81 @codecov-commenter @Trinkle23897 @MischaPanch