Bugfix/parallel launcher for linux #1141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a0cd0cb to
208b7bc
Compare
MischaPanch
commented
May 7, 2024
| experiment_runner: Callable[ | ||
| [Experiment], | ||
| InfoStats | None, | ||
| ] = lambda exp: exp.run().trainer_result, |
There was a problem hiding this comment.
Anticipating a question here: we can't return a list of ExperimentResult since it will contain an instance of World which is not picklable - joblib complains.
It would also be unnecessary to return all the worlds, they can be quite heavy.
So, instead we return the trainer_result object, which however can be None (but usually is not)
1. Launch in main process if only 1 exp is passed 2. Launcher returns a list of stats for successful exps 3. More detailed logging for unsuccessful expos 4. Raise error if all runs were unsuccessful 5. DataclassPPrintMixin allows retrieving a pretty repr string 6. Minor improvements in docstrings
208b7bc to
bf3859a
Compare
maxhuettenrauch
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1121
For details about changes see additions to changelog