这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@opcode81
Copy link
Collaborator

@opcode81 opcode81 commented Apr 30, 2024

  • I have added the correct label(s) to this Pull Request or linked the relevant issue(s)
  • I have provided a description of the changes in this Pull Request
  • I have added documentation for my changes and have listed relevant changes in CHANGELOG.md
  • If applicable, I have added tests to cover my changes.
  • I have reformatted the code using poe format
  • I have checked style and types with poe lint and poe type-check
  • (Optional) I ran tests locally with poe test
    (or a subset of them with poe test-reduced) ,and they pass
  • (Optional) I have tested that documentation builds correctly with poe doc-build

Description of changes: see individual commits; should be merged without squashing.

Co-authored by: @maxhuettenrauch

Partly addressed #1129

  * Add class ExperimentCollection to improve usability
  * Remove parameters from ExperimentBuilder.build
  * Renamed ExperimentBuilder.build_default_seeded_experiments to build_seeded_collection,
    changing the return type to ExperimentCollection
  * Replace temp_config_mutation (which was not appropriate for the public API) with
    method copy (which performs a safe deep copy)
@opcode81 opcode81 added high-level-api Mainly affects tianshou.highlevel experiment-eval Issues about evaluation: plots, stats, multiprocessing etc. labels Apr 30, 2024
@opcode81 opcode81 requested a review from MischaPanch April 30, 2024 15:48
@MischaPanch MischaPanch marked this pull request as ready for review April 30, 2024 20:52
@MischaPanch MischaPanch enabled auto-merge May 5, 2024 14:24
@MischaPanch MischaPanch disabled auto-merge May 5, 2024 19:41
@MischaPanch MischaPanch merged commit 9fbf28e into thu-ml:master May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

experiment-eval Issues about evaluation: plots, stats, multiprocessing etc. high-level-api Mainly affects tianshou.highlevel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants