Added support for minibatch in PPO process_fn #1168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trinkle23897
approved these changes
Jul 6, 2024
Collaborator
|
This looks innocent, but tests fail. I'll have a look at what goes wrong and will finalize this. Sorry for the late reaction, my official work has moved me in another direction for a few months, but now I'm back to devoting time to tianshou :) |
Collaborator
|
Looks like just a typo, |
Collaborator
|
Ok, I had a closer look. The current handling is a bit confusing, there is |
259e426 to
918c122
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1164
In PPOPolicy, the method
process_fn()now computeslogp_oldin minibatch instead of all at once.