Draft: for explicit seed mechanism of train seed, specific test seeds #1031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MischaPanch
reviewed
Jan 23, 2024
| """ | ||
| self._assert_is_not_closed() | ||
| seed_list: list[None] | list[int] | ||
| if seed is None: | ||
| if seed is None: #todo robert check this can happen, results in error when put in config |
MischaPanch
requested changes
Jan 23, 2024
bordeauxred
commented
Jan 26, 2024
| @@ -0,0 +1,12 @@ | |||
| from tbparse import SummaryReader | |||
There was a problem hiding this comment.
Alternatives to using tbparse are
- from tensorboard.backend.event_processing import event_accumulator
- convert to csv https://github.com/aai-institute/tianshou/blob/master/examples/mujoco/tools.py (this would allow to extend the custom plotter https://github.com/aai-institute/tianshou/blob/master/examples/mujoco/plotter.py) (so prob. preferable)
|
Superseded by #1074 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
poe formatpoe lintandpoe type-checkpoe test(or a subset of them with
poe test-reduced) ,and they passpoe doc-build