这是indexloc提供的服务，不要输入任何密码
Skip to content

Add vecenv wrappers for obs_norm to support running mujoco experiment with envpool #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 5, 2022
Merged

Add vecenv wrappers for obs_norm to support running mujoco experiment with envpool #628

merged 5 commits into from
May 5, 2022

Conversation

Trinkle23897
Copy link
Collaborator

@Trinkle23897 Trinkle23897 commented May 4, 2022 •
edited
Loading

  • add VectorEnvWrapper and VectorEnvNormObs
  • obs_rms store in policy save/load
  • align mujoco scripts with atari: obs_norm, envpool, wandb and README

@Trinkle23897 Trinkle23897 requested a review from ChenDRAG May 4, 2022 22:33
@Trinkle23897 Trinkle23897 linked an issue May 5, 2022 that may be closed by this pull request
Issues on loading a policy #443
Closed
8 tasks
@codecov-commenter
Copy link

codecov-commenter commented May 5, 2022 •
edited
Loading

Codecov Report

Merging #628 (96902d1) into master (a7c789f) will increase coverage by 0.05%.
The diff coverage is 86.66%.

@@            Coverage Diff             @@
##           master     #628      +/-   ##
==========================================
+ Coverage   93.49%   93.55%   +0.05%     
==========================================
  Files          68       69       +1     
  Lines        4567     4608      +41     
==========================================
+ Hits         4270     4311      +41     
  Misses        297      297
Flag Coverage Δ
unittests 93.55% <86.66%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tianshou/env/venv_wrappers.py 85.18% <85.18%> (ø)
tianshou/__init__.py 100.00% <100.00%> (ø)
tianshou/env/__init__.py 71.42% <100.00%> (+4.76%) ⬆️
tianshou/env/venvs.py 94.40% <100.00%> (+2.68%) ⬆️
tianshou/policy/modelfree/trpo.py 94.91% <0.00%> (+5.08%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@Trinkle23897 Trinkle23897 requested a review from nuance1979 May 5, 2022 02:36
nuance1979
nuance1979 approved these changes May 5, 2022
View reviewed changes
Copy link
Collaborator

@nuance1979 nuance1979 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trinkle23897 Trinkle23897 merged commit 2a7c151 into thu-ml:master May 5, 2022
@Trinkle23897 Trinkle23897 deleted the venv-norm branch May 5, 2022 11:55
BFAnas pushed a commit to BFAnas/tianshou that referenced this pull request May 5, 2024
@Trinkle23897
Add vecenv wrappers for obs_norm to support running mujoco experiment…
b648626 
… with envpool (thu-ml#628)

- add VectorEnvWrapper and VectorEnvNormObs
- obs_rms store in policy save/load
- align mujoco scripts with atari: obs_norm, envpool, wandb and README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuance1979 nuance1979 nuance1979 approved these changes

@ChenDRAG ChenDRAG Awaiting requested review from ChenDRAG

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues on loading a policy
3 participants
@Trinkle23897 @codecov-commenter @nuance1979