这是indexloc提供的服务，不要输入任何密码
Skip to content

Enable venvs.reset() concurrent execution #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 7, 2022
Merged

Enable venvs.reset() concurrent execution #517

merged 5 commits into from
Feb 7, 2022

Conversation

@gogoduan
Copy link
Contributor

@gogoduan gogoduan commented Feb 3, 2022 •
edited by Trinkle23897
Loading

  • change the internal API name of worker: send_action -> send, get_result -> recv (align with envpool)
  • add a timing test for venvs.reset() to make sure the concurrent execution
  • change venvs.reset() logic

@Trinkle23897 Trinkle23897 changed the title Update venvs.py Enable venvs.reset() concurrent execution Feb 7, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2022 •
edited
Loading

Codecov Report

Merging #517 (d3e2d15) into master (cd7654b) will decrease coverage by 0.04%.
The diff coverage is 90.24%.

❗ Current head d3e2d15 differs from pull request most recent head fd8eee9. Consider uploading reports for the commit fd8eee9 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #517      +/-   ##
==========================================
- Coverage   94.41%   94.37%   -0.05%     
==========================================
  Files          63       63              
  Lines        4246     4249       +3     
==========================================
+ Hits         4009     4010       +1     
- Misses        237      239       +2
Flag Coverage Δ
unittests 94.37% <90.24%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tianshou/env/worker/base.py 79.06% <75.00%> (+2.32%) ⬆️
tianshou/env/worker/dummy.py 89.28% <75.00%> (-3.03%) ⬇️
tianshou/env/worker/ray.py 85.36% <83.33%> (-1.82%) ⬇️
tianshou/env/venvs.py 91.61% <100.00%> (ø)
tianshou/env/worker/subproc.py 94.07% <100.00%> (-0.04%) ⬇️
tianshou/policy/modelfree/npg.py 97.70% <0.00%> (-1.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd7654b...fd8eee9. Read the comment docs.

@Trinkle23897 Trinkle23897 merged commit 9c100e0 into thu-ml:master Feb 7, 2022
BFAnas pushed a commit to BFAnas/tianshou that referenced this pull request May 5, 2024
@gogoduan @Trinkle23897
Enable venvs.reset() concurrent execution (thu-ml#517)
4372666 
- change the internal API name of worker: send_action -> send, get_result -> recv (align with envpool)
- add a timing test for venvs.reset() to make sure the concurrent execution
- change venvs.reset() logic

Co-authored-by: Jiayi Weng <trinkle23897@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trinkle23897 Trinkle23897 Trinkle23897 approved these changes

@youkaichao youkaichao Awaiting requested review from youkaichao

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gogoduan @codecov-commenter @Trinkle23897