-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Closed
Labels
breaking changesChanges in public interfaces. Includes small changes or changes in keysChanges in public interfaces. Includes small changes or changes in keysmajorLarge changes that cannot or should not be broken down into smaller onesLarge changes that cannot or should not be broken down into smaller onesrefactoringNo change to functionalityNo change to functionality
Milestone
Description
That's a tricky one since learn
implementation are currently not cleanly separated (violate Liskov substitution) and rely on kwargs in order to remain functional. E.g. some implementations of learn take the repeat
kwarg (the on-policy ones), and some don't.
Generally, the control flow between trainer.update_policy
and policy.learn
may need to be redesigned or at least improved
Metadata
Metadata
Assignees
Labels
breaking changesChanges in public interfaces. Includes small changes or changes in keysChanges in public interfaces. Includes small changes or changes in keysmajorLarge changes that cannot or should not be broken down into smaller onesLarge changes that cannot or should not be broken down into smaller onesrefactoringNo change to functionalityNo change to functionality
Type
Projects
Status
Done