-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Closed
Labels
breaking changesChanges in public interfaces. Includes small changes or changes in keysChanges in public interfaces. Includes small changes or changes in keysgood first issueGood for newcomersGood for newcomersminorRequires small changes to be fixedRequires small changes to be fixedrefactoringNo change to functionalityNo change to functionality
Description
It's not really a useful method and bloats the interface. The documentation already shows the intricacies of using it with recurse=True or recurse=False.
It's more explicit to replace it with
batch.is_empty() -> len(batch.get_keys()) == 0batch.is_empty(recurse=True) -> len(batch) == 0
Solving this means using the IDE's find usages, applying the above replacements, and removing is_emtpy from Batch and BatchProtocol
Metadata
Metadata
Assignees
Labels
breaking changesChanges in public interfaces. Includes small changes or changes in keysChanges in public interfaces. Includes small changes or changes in keysgood first issueGood for newcomersGood for newcomersminorRequires small changes to be fixedRequires small changes to be fixedrefactoringNo change to functionalityNo change to functionality