这是indexloc提供的服务,不要输入任何密码
Skip to content

Batch: remove is_empty #1108

@MischaPanch

Description

@MischaPanch

It's not really a useful method and bloats the interface. The documentation already shows the intricacies of using it with recurse=True or recurse=False.

It's more explicit to replace it with

  1. batch.is_empty() -> len(batch.get_keys()) == 0
  2. batch.is_empty(recurse=True) -> len(batch) == 0

Solving this means using the IDE's find usages, applying the above replacements, and removing is_emtpy from Batch and BatchProtocol

Metadata

Metadata

Labels

breaking changesChanges in public interfaces. Includes small changes or changes in keysgood first issueGood for newcomersminorRequires small changes to be fixedrefactoringNo change to functionality

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions