Fix for non-ascii filenames #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed "The header content contains invalid characters" error thrown by Express on non-ascii filenames according to: https://tools.ietf.org/html/rfc6266#section-6
Owner
|
Thanks for the patch, @yalanyali! Looks like the tests are failing. If you want to resolve those I can merge, and/or I'll make a note to circle back and try to get those written and this merged a little later. |
Author
|
Well, I've changed the content-disposition string to support UTF-8 characters. Tests are failing because they're expecting a certain match. I'd have to change the tests in order for them to not fail, which is something I wouldn't do. I've been using my own branch of this library on my project and I feel like it's a decision the maintainer should make, so it's up to you. Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed "The header content contains invalid characters" error thrown by Express on non-ascii filenames according to:
https://tools.ietf.org/html/rfc6266#section-6