chore: remove libarchive-tools from workflow. #838
Conversation
dc497f0 to
3f93f5a
Compare
robertkirkman
left a comment
There was a problem hiding this comment.
It is still working exactly correctly on apt and working at runtime, and the contents of the package are extremely similar to the contents of an older version
diff -burN termux-x11-deb-old/control termux-x11-deb-new/control
--- termux-x11-deb-old/control 2023-08-06 15:30:55.000000000 -0500
+++ termux-x11-deb-new/control 2025-04-09 12:02:19.000000000 -0500
@@ -1,7 +1,7 @@
Package: termux-x11-nightly
Architecture: all
Maintainer: Twaik Yont @twaik
-Version: 1.03.00-0
+Version: 1.03.01-0
Homepage: https://github.com/termux/termux-x11
Depends: xkeyboard-config
Description: Companion package for termux-x11 app
Binary files termux-x11-deb-old/control.tar.gz and termux-x11-deb-new/control.tar.gz differ
diff -burN termux-x11-deb-old/data/data/com.termux/files/usr/bin/termux-x11 termux-x11-deb-new/data/data/com.termux/files/usr/bin/termux-x11
--- termux-x11-deb-old/data/data/com.termux/files/usr/bin/termux-x11 2023-08-06 15:30:55.000000000 -0500
+++ termux-x11-deb-new/data/data/com.termux/files/usr/bin/termux-x11 2025-04-09 12:02:19.000000000 -0500
@@ -1,4 +1,7 @@
#!/data/data/com.termux/files/usr/bin/sh
+[ -z "${LD_LIBRARY_PATH+x}" ] || export XSTARTUP_LD_LIBRARY_PATH="$LD_LIBRARY_PATH"
+[ -z "${LD_PRELOAD+x}" ] || export XSTARTUP_LD_PRELOAD="$LD_PRELOAD"
+[ -z "${CLASSPATH+x}" ] || export XSTARTUP_CLASSPATH="$CLASSPATH"
export CLASSPATH=/data/data/com.termux/files/usr/libexec/termux-x11/loader.apk
unset LD_LIBRARY_PATH LD_PRELOAD
-exec /system/bin/app_process / com.termux.x11.Loader "$@"
+exec /system/bin/app_process -Xnoimage-dex2oat / --nice-name="termux-x11 com.termux.x11 $*" com.termux.x11.Loader "$@"
Binary files termux-x11-deb-old/data/data/com.termux/files/usr/libexec/termux-x11/loader.apk and termux-x11-deb-new/data/data/com.termux/files/usr/libexec/termux-x11/loader.apk differ
Binary files termux-x11-deb-old/data.tar.xz and termux-x11-deb-new/data.tar.xz differ
diff -burN termux-x11-deb-old/postinst termux-x11-deb-new/postinst
--- termux-x11-deb-old/postinst 1969-12-31 18:00:00.000000000 -0600
+++ termux-x11-deb-new/postinst 2025-04-09 12:02:19.000000000 -0500
@@ -0,0 +1,2 @@
+#!/data/data/com.termux/files/usr/bin/sh
+chmod -w /data/data/com.termux/files/usr/libexec/termux-x11/loader.apk|
Well, I noticed some small details but, I am not sure if they are important, since it seems to work without them exactly matching to the way they were before. with the current But with this one, it looks like this and with the current one, I think but with this one, the |
3f93f5a to
4550b16
Compare
Updating apt repositories and installing libarchive-tools takes some time. We can avoid wasting this time and generate pacman package without it. Also fetching the whole repo seems to be redunant, we do not need to fetch history.
4550b16 to
8152472
Compare
Yep, bsdtar is only used to generate pacman package.
They only important thing is to keep I populated pacman bootstrap in AVD and now I know this package is installable and it works. |
Updating apt repositories and installing libarchive-tools takes some time. We can avoid wasting this time and generate pacman package without it.
@Maxython @robertkirkman I will be appreciated for review and probably on-device test.