-
-
Notifications
You must be signed in to change notification settings - Fork 442
Fix xshmfence #764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix xshmfence #764
Conversation
|
LGTM. By the way, can you please take a look at the reason why vkcube does not work with dri3+swrast? |
|
And one more question. Is https://github.com/xMeM/termux-packages/tree/dev/wrapper ready? Issues are disabled in your fork. |
Maybe these changes will fix it? vkcube works fine with dri3+swrast now, it was a black screen before applying the changes. |
|
Correct, it fixes vkcube with working dri3 and does not seem to break mesa so I'll merge it. |
|
What about vulkan wrapper branch? Is it ready? Probably it is time to file a pull request to termux org repo. |
Ok, I'll open a pull request tomorrow. |
|
So this PR makes https://github.com/termux/termux-packages/blob/master/packages/mesa-vulkan-icd-freedreno-dri3/wsi-termux-x11.patch not needed, right? |
|
I thought we need to mmap file descriptor we pass there with some offset we get from the |
Yes, |
It seems that only YUV formats have offsets, since those formats have multiple planes. |
|
@xMeM, after your patch in termux-x11, mesa-glibc stopped working (all drivers). I already tried to rebuild mesa-glibc without |
|
https://github.com/termux/termux-packages/blob/187b1de5bc32613574bf43ca22102ab4014c512e/packages/libxshmfence/build.sh#L10 |
|
@xMeM, I rebuilt And also, could you look at the |
|
@Maxython libxshmfence fallback to pthread shared mutex after futex is disabled, but glibc cannot share mutex with bionic. |
|
Is it possible to port pthread mutex-related code to glibc from bionic? It should be relatively easy. |
|
I mean for using it only inside xshmfence lib. |
|
It is weird, it looks like pthread uses futex internally (__NR_futex syscall). |
|
@xMeM However, I build and tested The build process is as follows, but is there something I may have missed or done incorrectly? vkcube.mp4 |
|
@hansm629 For glibc build, it is still necessary to apply the DRI3 patch. |
|
Frankly speaking, as a developer of glibc packages in Termux, I started to doubt whether these changes are right. Because the new termux-x11 does not simplify the compilation of the |
|
@Maxython Just keep the DRI3 patch for mesa-glibc, no changes to other packages are needed. |
These changes allow Mesa Turnip DRI3 to work without patches.