Let Termux:X11 run without sharedUserId="com.termux" #31

twaik · 2021-09-11T21:31:38Z

Solves #21
Pay attention. After compiling you should copy $repo/starter/build/intermediates/stripped_native_libs/debug/out/lib/$TARGET_ARCH/libstarter.so (or extract from apk (lib/$TARGET_ARCH/libstarter.so)) to $TERMUX_PREFIX/libexec/termux-x11/libstarter.so. Also you should put $repo/starter/build/outputs/apk/debug/starter-debug.apk to $TERMUX_PREFIX/libexec/termux-x11/starter.apk
I think we can use this build.sh as a reference.

P.S. Almost forgot $repo/termux-x11 script. It should be copied to $TERMUX_PREFIX/bin/

Remove/ignore build.gradle changing to prevent downgrading gradle plugin.
Remove hardcoding $XDG_RUNTIME_DIR in sources. Replace with checking if it is set in environment and export default value if it is not exported.
Start Xwayland if/when connection is established.
Send RUN_COMMAND intent if an app was started from launcher, not from commandline.
Implement a way to extract logs. Maybe we will pass fd of logfile next to socket's fd and write output of logcat (logcat started in an app can extract logs of the app and apps with the same android:sharedUserId).
Implement a way to read termux.properties file. Using fd sending or through Termux's ContentProvider
A way to avoid using JNI to extract non-basic arguments (not int/long/boolean types).
Implement mechanism of avoiding errors if there is an API version mismatch. Maybe we can just not perform an action if there is RemoteException error.

twaik · 2021-09-11T21:54:28Z

@xeffyr Hi. Can we make a new package for apt repos or we should test it longer?

creepy-pasta101

Pay attention. After compiling you should copy $repo/starter/build/intermediates/stripped_native_libs/debug/out/lib/$TARGET_ARCH/libstarter.so (or extract from apk (lib/$TARGET_ARCH/libstarter.so)) to $TERMUX_PREFIX/libexec/termux-x11/libstarter.so. Also you should put $repo/starter/build/outputs/apk/debug/starter-debug.apk to $TERMUX_PREFIX/libexec/termux-x11/starter.apk

Abou that... I suggest using termux's own RUN_COMMAND intent

build.gradle

starter/src/main/jni/starter.c

twaik · 2021-09-12T05:20:47Z

I suggest using termux's own RUN_COMMAND intent

It should be done just one time after package installation. Do you think I should install it using RUN_COMMAND, not pkg/apt?

creepy-pasta101 · 2021-09-12T05:23:48Z

It should be done just one time after package installation

Then I guess adding it to termux-packages/packages/termux-x11 would be better

twaik · 2021-09-12T05:24:03Z

termux-x11 script is needed to run starter.apk which creates socket and sends server file descriptor to termux-x11 app. It is impossible to use termux's private directories without android:sharedUserId.

twaik · 2021-09-12T05:32:08Z

Also I forgot to complete a code which starts Xwayland in the end. Maybe we will make something like starting XFCE/other DE session after Xwayland. That will allow us to send RUN_COMMAND to termux to avoid writing any commands. Less movements. And also it will start all the stuff after receiving SECONDARY_HOME intent.

twaik · 2021-09-12T05:34:22Z

@suhan-paradkar do you think an app should check API version used in starter.apk? That will help to avoid segfault when versions of termux-x11 and starter.apk do not match.

creepy-pasta101 · 2021-09-12T05:39:15Z

I guess better would be to add a logger to the app and also bump the version of termux-x11 script whenever starter.apk is updated.. this means a pkg update by the user wil solve it all

twaik · 2021-09-12T08:33:36Z

That can be a bit problematic. I mean mechanism of extracting logs. Maybe I can add extra argument for extracting log of previous run. I think I will do that after cleaning up the code and separation debug/verbose and release logging mode.

twaik · 2021-09-12T18:14:03Z

There is a problem. When JNI code tries to use JNIEnv* env it segfaults. And JNI_OnLoad function gets JavaVM *vm = NULL. What is a problem? Maybe there is a solution?
@agnostic-apollo @xeffyr

creepy-pasta101

So far so good

starter/src/main/java/com/termux/x11/starter/Starter.java

Make Termux:X11 start user-defined commands in Termux ($PREFIX/libexec/termux-x11/termux-startx11) Make debug_build.yml build companion package for termux and upload it as an artifact. Update README.md

twaik · 2021-10-01T16:15:07Z

I think it is ready to be merged.
Last artifact contains both apk and deb file of companion package.
@suhan-paradkar @wmcb-tech
Can you please test it?
Maybe I should add something?

RalfWerner · 2021-10-01T18:44:47Z

I checked your Artifact on one of my devices but not studied your descriptions above (do it tomorrow), and made comparison:

Installation as the update of the last version is not possible (only after de-install)
Fullscreen mode is not included and the Extra Keys correspond to your base version (not ekeys).
As XServer I could not use this app by OTS but get short messages.

twaik · 2021-10-01T19:34:04Z

@RalfWerner

This version is signed with different key. That is a reason update process fails.
Fullscreen mode commit is located in ekeys branch which is still not merged. There is no reason to use it as a base branch.
After tapping on application icon in launcher T:X11 triggers termux-app to run script $PREFIX/libexec/termux-x11/termux-startx11. Also this script may be used to start X11 session from Termux session.
This script starts termux-x11 binary to create and export socket to termux-x11 app, starts Xwayland and x-session-manager.
x-session-manager is symlink to xfce-session. You can override it to be a link to your script.
You do not need to use 3rd party scripts starting termux-x11. The process of starting it has changed and it is incompatible with previous versions.

ghost · 2021-10-02T00:45:37Z

I think it is ready to be merged.
Last artifact contains both apk and deb file of companion package.
@suhan-paradkar @wmcb-tech
Can you please test it?
Maybe I should add something?

~~Good morning folks! during the installation it fails for some reason. so i have to switch to Termux F-droid or something @twaik ?~~

Ok now it works after uninstalling and reinstalling the app. felt dumb

ghost · 2021-10-02T04:10:51Z

the termux-x11 package dependency needs to be xwayland and not Xwayland since it's case sensitive apt will report a non-existent package. repacking the deb fixed it

RalfWerner · 2021-10-02T06:08:02Z

Ok now it works after uninstalling and reinstalling the app. felt dumb

@wmcb-tech My experiance! Where dit you find $PREFIX/libexec/termux-x11/termux-startx11 to start xwayland process?
With "felt dumb" I agree! What practical advantage should have this branch? Its more worse than basic X11

twaik · 2021-10-02T17:01:36Z

the termux-x11 package dependency needs to be xwayland and not Xwayland since it's case sensitive apt will report a non-existent package. repacking the deb fixed it

Fixed

Where dit you find $PREFIX/libexec/termux-x11/termux-startx11 to start xwayland process?

It is present in companion package. Now installation is fixed.

What practical advantage should have this branch? Its more worse than basic X11

It is better because it can be used with any version of termux, even signed with another key. There are not many people who rebuilds/resigns their application in order to guarantee compatibility.

twaik · 2021-10-02T17:55:16Z

@wmcb-tech Does it work well? Do you think it can be merged?

ghost · 2021-10-03T01:56:14Z

@wmcb-tech Does it work well? Do you think it can be merged?

I just moved to F-droid version of Termux for testing and it seems it does work fine (although additional steps need to be done like permission granting and setting allow-external-apps = true needs to be set)

i think it's ready to merge as it's works flawlessly not having to use debug builds of Termux

twaik · 2021-10-03T10:32:16Z

additional steps need to be done like permission granting

It is impossible to override it. And it is needed only to start termux-startx11 command from external app.

allow-external-apps = true needs to be set

I prefer not to do that automatically because it can impact termux-app's security.

Ok. I am merging it.

twaik requested a review from creepy-pasta101 September 11, 2021 21:31

creepy-pasta101 suggested changes Sep 12, 2021

View reviewed changes

build.gradle Outdated Show resolved Hide resolved

starter/src/main/jni/starter.c Outdated Show resolved Hide resolved

starter/src/main/jni/starter.c Outdated Show resolved Hide resolved

twaik requested a review from creepy-pasta101 September 27, 2021 09:06

twaik self-assigned this Sep 27, 2021

twaik added the enhancement New feature or request label Sep 27, 2021

creepy-pasta101 reviewed Sep 27, 2021

View reviewed changes

starter/src/main/java/com/termux/x11/starter/Starter.java Show resolved Hide resolved

twaik requested a review from creepy-pasta101 October 1, 2021 14:20

Let Termux:X11 run without sharedUserId="com.termux"

a183461

Make Termux:X11 start user-defined commands in Termux ($PREFIX/libexec/termux-x11/termux-startx11) Make debug_build.yml build companion package for termux and upload it as an artifact. Update README.md

bugfix

dc6984b

twaik merged commit f9a9ce3 into termux:master Oct 3, 2021

twaik mentioned this pull request Oct 8, 2021

[Feature request] Using termux-wayland without need to compile it with Termux key. #21

Closed

Uh oh!

Let Termux:X11 run without sharedUserId="com.termux" #31

Let Termux:X11 run without sharedUserId="com.termux" #31

Uh oh!

Conversation

twaik commented Sep 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

twaik commented Sep 11, 2021

Uh oh!

creepy-pasta101 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

twaik commented Sep 12, 2021

Uh oh!

creepy-pasta101 commented Sep 12, 2021

Uh oh!

twaik commented Sep 12, 2021

Uh oh!

twaik commented Sep 12, 2021

Uh oh!

twaik commented Sep 12, 2021

Uh oh!

creepy-pasta101 commented Sep 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

twaik commented Sep 12, 2021

Uh oh!

twaik commented Sep 12, 2021

Uh oh!

creepy-pasta101 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

twaik commented Oct 1, 2021

Uh oh!

RalfWerner commented Oct 1, 2021

Uh oh!

twaik commented Oct 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Oct 2, 2021 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Oct 2, 2021 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RalfWerner commented Oct 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

twaik commented Oct 2, 2021

Uh oh!

twaik commented Oct 2, 2021

Uh oh!

ghost commented Oct 3, 2021

Uh oh!

twaik commented Oct 3, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

twaik commented Sep 11, 2021 •

edited

Loading

creepy-pasta101 commented Sep 12, 2021 •

edited

Loading

twaik commented Oct 1, 2021 •

edited

Loading

ghost commented Oct 2, 2021 •

edited by ghost

Loading

ghost commented Oct 2, 2021 •

edited by ghost

Loading

RalfWerner commented Oct 2, 2021 •

edited

Loading