OpenXR - BT/OTG support and hardcode native resolution #671
Conversation
| if (XrActivity.isEnabled()) { | ||
| width = 1024; | ||
| height = 1024; | ||
| } |
There was a problem hiding this comment.
Probably it will be better to use some 16:9 or at least 4:3 resolution. 1:1 resolution are not the best for human eye perception.
| // Bluetooth/OTG keyboards work properly with the standard flow | ||
| if (hasFocus) { | ||
| return super.dispatchKeyEvent(event); | ||
| } |
There was a problem hiding this comment.
There is hasWindowFocus function, no need to store current window focus value in separate variable.
| } | ||
|
|
||
| @Override | ||
| public boolean dispatchKeyEvent(KeyEvent event) { |
There was a problem hiding this comment.
Does LorieView's dispatchKeyEventPreIme work in the case if Activity's dispatchKeyEvent is overridden?
There was a problem hiding this comment.
Software keyboard sends randomly event with KEYCODE_MEDIA_PLAY into dispatchKeyEventPreIme.
Hardware keyboard works sends correct events into dispatchKeyEventPreIme.
There was a problem hiding this comment.
I am sorry, I do not understand how is your question related to the code.
What change do you require here?
|
There are pending reviews. |
|
@lvonasek can you please read pending reviews and respond? |
|
I responded to not answered reviews (although I thought this was clear, I am sorry for the misunderstanding). About the answer from @natebragg:
I think the user reacted to ctrl+space issue which isn't expected to work in the XR mode neither (the same issue like #665). |
|
They are still considered to be pending. |
There must be some issue with GitHub. These comments aren't visible for me. But let me clarify it here: These events are not passing into I personally prefer to avoid "hacky" code if it is not necessary. |
|
What about the last one? |
Yes, |
|
@lvonasek Is it possible to add support for other OpenXR-Compatible devices using the Monado runtime for Android? Monado has drivers for Nreal Air/Pro and Rokid glasses. I enjoy using OpenXR mode for Termux-X11 on the Quest, but being able to use it on my glasses would be great! |
|
This addresses XR issues mentioned in #665.
AndroidManifest.xml)LorieView.java)XrActivity.java)