Fix touchpad transform having no effect #650
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Touchpad transform currently has no effect because the TouchInputHandler mTouchpadHandler does not receive updates to the config. I looked through the uses of it and found out that although one could apply a far simpler patch, the mTouchpadHandler actually has no extra functionality and can be removed without any change in behavior. This both reduces code complexity and fixes the touchpad transform.
If this solution is unwanted, I can move to the smaller patch instead - though I personally don't see any metric where that solution would be better unless mTouchpadHandler has some very obscure function that I wasn't able to find or discover during preliminary testing.