fix add ic_settings icon to drawable
#249
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Is it final? Can I merge it when check finishes? |
Contributor
Author
i tested apk also , now its showing properly. |
Member
|
Did you test it with dark theme? |
Contributor
Author
|
Member
|
Can you please make it fit to theme? Black on light theme and white on dark theme? |
Contributor
Author
Okay i will try. |
Member
|
Can you please show how it looks like in different themes? |
Contributor
Author
not completed still |
Contributor
Author
|
Closing untill completed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix : Settings icon not display in shortcut.