tree-wide: code style and print message cleanup #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Continuation of termux#179, particularly these topics from there: - termux#179 (review) - termux#179 (comment) - Contains things that were proposed there, but that it was decided to separate out into another PR for organization and easier review - Replaces space intendation with tab indentation in shell scripts - Replaces backtick command substitution syntax with dollar symbol and parentheses command substitution syntax in shell scripts - Places double quote symbols around all string (non-numerical) variable references that aren't possibly-empty references in the argument lists of command invocations - (placing double quote symbols around a possibly-empty variable in a command invocation is a case where the double quote symbols would cause an error to happen) - Places double quote symbols around all instances of `@TERMUX_PREFIX@` and other replaced strings in `.sh.in` files - Moves instances of multiline `local` variable declarations into single lines anywhere that doing so wouldn't make the line more than 100 characters long - Remove unused function `hostname()` from `pkg` - Remove unused variable `PREFIX` from `termux-restore` - Unify and clarify instances of `login`-related error message in `chsh`
TomJo2000
approved these changes
Jun 29, 2025
Member
TomJo2000
left a comment
There was a problem hiding this comment.
I've been using this branch for my Apt 3.x testing and it is working as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of fix(scripts/login.in): don't canonicalize symlink value #179, particularly these topics from there:
Contains things that were proposed there, but that it was decided to separate out into another PR for organization and easier review
Replaces space indentation with tab indentation in shell scripts
Replaces backtick command substitution syntax with dollar symbol and parentheses command substitution syntax in shell scripts
Places double quote symbols around all string (non-numerical) variable references that aren't possibly-empty references in the argument lists of command invocations
Places double quote symbols around all instances of
@TERMUX_PREFIX@and other replaced strings in.infilesMoves instances of multiline
localvariable declarations into single lines anywhere that doing so wouldn't make the line more than 100 characters longRemove unused function
hostname()frompkgRemove unused variable
PREFIXfromtermux-restoreUnify and clarify instances of
login-related error message inchsh