这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@twaik
Copy link
Member

@twaik twaik commented May 15, 2025

A small change for targeted to newbies and stupid people like me who do not know how to read and/or ignore/not see dialog message.

@twaik twaik force-pushed the use-menu-instead-of-radiolist branch from f672804 to aac7a06 Compare May 15, 2025 07:11
Copy link
Member

@robertkirkman robertkirkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, ever since the beginning, I always just assumed that there was some specific reason why the --radiolist was used and not the --menu. I just got used to it.

Actually, I tested this, and there is an additional important benefit to this as well.

Previously, I always thought for some reason that the [*] was supposed to indicate the current setting in use whenever termux-change-repo was launched. Actually, when I checked, I can see that this was never the case, and actually the [*] was just misleadingly showing the same default every time termux-change-repo is launched, regardless of the current state of the setting stored.

This change is good because it removes the [*], making it a little clearer that the current state of the setting in storage does not affect the default highlighted selections each time termux-change-repo is run.

twaik and others added 3 commits May 15, 2025 19:49
Use bash builtins instead of external commands while scanning files.
…files to the format `Mirror by <owner>. Hosted in <location>` and show truncated description in `termux_change_repo` in the format `M: <owner>. <location>` so that important parts of description are viewable if terminal columns have a low value like default `60`
@agnostic-apollo agnostic-apollo force-pushed the use-menu-instead-of-radiolist branch from aac7a06 to be6e8ca Compare May 15, 2025 15:47
@agnostic-apollo
Copy link
Member

Nice find, thanks for this. I have tested it and seems to be working.

I have cherrypicked the commit from #168 and added be6e8ca as well. I dont see any option to modify column width to show full url or even scroll horizontally to see full text. Comparison below is 60 vs 69 columns.

Screenshot_1747323890
Screenshot_1747323977

@twaik
Copy link
Member Author

twaik commented May 15, 2025

image

@twaik twaik merged commit e91f05f into master May 15, 2025
1 check passed
@twaik twaik deleted the use-menu-instead-of-radiolist branch May 15, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants